Repository navigation
Support attributes on anonymous classes (new #[Attr] class {}) - #7
Merged
Merged
Conversation
An attribute group between new and an anonymous class, e.g.
new #[AsCommand(name: 'foo')] class extends Command {}, is now parsed and the
attribute groups attach to the class node, so it prints back unchanged.
Adds zero new goyacc conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An attribute group between
newand an anonymous class failed to parse:with
unexpected T_ATTRIBUTE. This is valid since PHP 8.0 and appears in e.g.symfony/console's tests.Change
internal/php8/php8.y): addT_NEW attributes anonymous_classtonew_non_dereferenceable; the attribute groups attach to the anonymous class node. Adds zero new goyacc conflicts.php8.go.StmtClass.AttrGroups, so these round-trip unchanged.internal/php8/attributes_on_anonymous_class_test.go(parse + print-back-unchanged).Verification
Full suite and golangci-lint pass. With reco pointed at this branch, a
type-coveragescan ofsymfony/consolenow completes with no syntax errors and no skipped files (combined with the octal and DNF fixes already released).